[Implemented] Undo command

Post any suggestions for new features in Openshot here.

Moderators: Andy, Cenwen, beats

[Implemented] Undo command

Postby hv_francesco » Fri Jan 22, 2010 3:42 pm

I have a first working proof-of-concept of a Undo/history system, but it's still buggy and unstable, and besides I'm not sure it's the best way to go.
It has the advantage that it doesn't need too many changes in existing code, as it tries to reshape a bit and use parts of code that are already there.
The down side is that it uses a rather "rough" concept, saving states of the project object in a stack serialized with cPickle, so restoring the previous state is not as fast as light.
I'm sure it can be done a lot better than this, so I hope that someone more experienced than I am can review my code and see if it is worth working on it or if it is totally dumb.

the branch is this:
lp:~francesco-hermanitosverdes/openshot/francesco_undo_redo_test

best regards to everyone
francesco
hv_francesco
Forum regular
 
Posts: 37
Joined: Wed Jan 06, 2010 4:07 pm

Re: Undo command

Postby Cenwen » Fri Jan 22, 2010 8:23 pm

Thanks for your work francesco. I have download your branches yesterday night but i have not yet tested this is. But for this is who have the icon effect is working well. Okay personnaly, i don't like the icon, but it's my personnal view. ;) In all cases, you have done a great work and i have not find a bug? But it was only a test.
Good work. :twisted:
Le jour où j'ai découvert le libre, j'ai su que je ne reviendrai jamais en arrière
Mon blog sur le multimédia, la photo et Openshot : http://linuxevolution.wordpress.com/
Google+ : https://plus.google.com/u/0/111472725110173916234/posts
User avatar
Cenwen
Moderator
 
Posts: 1609
Joined: Wed Nov 18, 2009 4:07 pm
Location: Clermont-Ferrand-Auvergne-France

Re: Undo command

Postby hv_francesco » Fri Jan 22, 2010 8:38 pm

Thank you. I put on a super-small screencast to show the first attempt to the undo stuff, I really hope I'm not pushing things in the wrong direction, and, as you can see, there are quite a lot of things to tweak and fix yet.
hv_francesco
Forum regular
 
Posts: 37
Joined: Wed Jan 06, 2010 4:07 pm

Re: Undo command

Postby Cenwen » Fri Jan 22, 2010 8:44 pm

okay very nice. That's look fine. :D
Could you create a icon but i don't know where in the timeline icon bar or in the menu icon? Where is the most easy for the user ?
If we are all like you, Openshot will grown like a ........................TGV. :lol:
Le jour où j'ai découvert le libre, j'ai su que je ne reviendrai jamais en arrière
Mon blog sur le multimédia, la photo et Openshot : http://linuxevolution.wordpress.com/
Google+ : https://plus.google.com/u/0/111472725110173916234/posts
User avatar
Cenwen
Moderator
 
Posts: 1609
Joined: Wed Nov 18, 2009 4:07 pm
Location: Clermont-Ferrand-Auvergne-France

Re: Undo command

Postby hv_francesco » Fri Jan 22, 2010 10:18 pm

I'm making some testing on a more complex project file, with a crowded timeline, because one of the problems of this approach is that, as long as the timeline grows more complex and the project more crowded, I suppose serialization-deserialization can take longer (not sure though).
It turns out that serialization is light-fast, and de-serialization/restoring of a previous state, seems to get a bit slower, but not much.
In my opinion cPickle is fast enough to handle this without problems, and the project restoring alghoritm can probably be optimized, but It is already better than I had feared.
hv_francesco
Forum regular
 
Posts: 37
Joined: Wed Jan 06, 2010 4:07 pm

Re: Undo command

Postby hv_francesco » Sat Jan 23, 2010 11:48 am

added more events to history tracking system, and a History panel in main window as in following screenshot:
history_panel.png
history_panel.png (94.92 KiB) Viewed 690 times
hv_francesco
Forum regular
 
Posts: 37
Joined: Wed Jan 06, 2010 4:07 pm

Re: Undo command

Postby gnowak » Tue Feb 23, 2010 6:06 pm

Great the undo command is what I miss the most.

How can I help?
User avatar
gnowak
New member
 
Posts: 4
Joined: Tue Feb 23, 2010 6:03 pm

Re: Undo command

Postby Cenwen » Tue Feb 23, 2010 7:03 pm

She is included in the version 1.1.0 with an history (undo/rendo) and it will be soon. Stay tuned. :D
Le jour où j'ai découvert le libre, j'ai su que je ne reviendrai jamais en arrière
Mon blog sur le multimédia, la photo et Openshot : http://linuxevolution.wordpress.com/
Google+ : https://plus.google.com/u/0/111472725110173916234/posts
User avatar
Cenwen
Moderator
 
Posts: 1609
Joined: Wed Nov 18, 2009 4:07 pm
Location: Clermont-Ferrand-Auvergne-France

Re: Undo command

Postby gnowak » Tue Feb 23, 2010 7:56 pm

Sweeet!! :P
User avatar
gnowak
New member
 
Posts: 4
Joined: Tue Feb 23, 2010 6:03 pm

Re: Undo command

Postby Madspyman » Sun Feb 28, 2010 6:32 am

Version 1.1.0-alpha2 is in Ubuntu Lucid alpha3 already, so I've tried the undo out and it's good.
Madspyman
New member
 
Posts: 4
Joined: Thu Feb 18, 2010 5:47 pm

Re: Undo command

Postby Cenwen » Sun Feb 28, 2010 11:29 am

Thanks for the feedback. We are in an intensive period of tests so all feedback is welcome. ;)
Le jour où j'ai découvert le libre, j'ai su que je ne reviendrai jamais en arrière
Mon blog sur le multimédia, la photo et Openshot : http://linuxevolution.wordpress.com/
Google+ : https://plus.google.com/u/0/111472725110173916234/posts
User avatar
Cenwen
Moderator
 
Posts: 1609
Joined: Wed Nov 18, 2009 4:07 pm
Location: Clermont-Ferrand-Auvergne-France


Return to Feature requests

Who is online

Users browsing this forum: No registered users

cron